All patches to Telepathy components are reviewed by (hopefully) more experienced developers of the components to ensure that they meet standards of code quality, understandability and maintainability.
Procedure
Record your changes in a Git branch. See Git for details on how to get started.
Publish your branch online somewhere; we suggest requesting a freedesktop.org account, or you can use your own webspace or any public git hosting site (gitorious, github etc.).
- Ping one of the reviewers listed below with your branch URL, on IRC, by e-mail to the mailing list, or in a bug with the 'patch' keyword (using a bug is recommended for complex patches or if we don't respond to IRC pings). The reviewer may ask you some questions and ask you to make some changes to your patch.
- When they approve it, you can commit it if you have access, or the reviewer may commit it for you.
Reviewers
The maintainer is responsible for making or delegating releases, and decides who can be a reviewer. Most reviewers can be found on #telepathy.
When reviewing, please pay attention to Style] and [[Portability.
To review a patch in a bug, comment on it, and then in the whiteboard mark review+ or review-
All fd.o Telepathy bugs with patches
Module |
Maintainer |
Other reviewers |
Bugzilla review queue |
empathy |
cassidy |
Zdra, danni, sjoerd, jonnylamb, Cosimoc |
|
papyon |
lfrb |
KaKaRoTo, istaz |
|
telepathy-butterfly |
jonnylamb |
istaz |
|
telepathy-doc |
danni |
... |
|
telepathy-farsight |
ocrete |
... |
|
telepathy-gabble |
smcv |
Robot101, cassidy, wjt, ptlo, daf |
|
telepathy-glib |
smcv |
Robot101, wjt, ... |
|
telepathy-haze |
wjt |
jonnylamb, smcv (when he's not busy with all his other components), Robot101 (when he's feeling masochistic), Maiku |
|
telepathy-idle |
wjt |
oggis, sjoerd, jonnylamb, smcv |
|
telepathy-inspector |
smcv |
sjoerd |
|
telepathy-logger |
stormer |
pochu, danni |
|
telepathy-mission-control |
smcv |
mardy, ... |
|
telepathy-pinnochio |
treitter |
... |
|
telepathy-python |
cassidy |
jonnylamb |
|
telepathy-qt4 |
smcv |
andrunko, oggis |
|
telepathy-salut |
sjoerd |
... |
|
telepathy-sofiasip |
mikhailz |
ptlo |
|
telepathy-spec |
Robot101/smcv |
the telepathy-spec cabal¹ |
|
tictactube |
epmf |
(none) |
|
Notes
1. substantial telepathy-spec changes should usually be discussed by several component maintainers